Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, tests: move more test cases from join_test.go and write_test.go to integrationtest #47420

Merged
merged 4 commits into from
Oct 8, 2023
Merged

executor, tests: move more test cases from join_test.go and write_test.go to integrationtest #47420

merged 4 commits into from
Oct 8, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Oct 7, 2023

What problem does this PR solve?

Issue Number: ref #47076

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 7, 2023
@tiprow
Copy link

tiprow bot commented Oct 7, 2023

Hi @SeaRise. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Merging #47420 (ec06e28) into master (413a58f) will increase coverage by 0.5298%.
Report is 12 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47420        +/-   ##
================================================
+ Coverage   72.2792%   72.8090%   +0.5298%     
================================================
  Files          1352       1373        +21     
  Lines        400847     407863      +7016     
================================================
+ Hits         289729     296961      +7232     
- Misses        91920      92095       +175     
+ Partials      19198      18807       -391
Flag Coverage Δ
integration 38.7224% <ø> (?)
unit 72.3771% <ø> (+0.0979%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.7651% <ø> (+0.0107%) ⬆️
br 48.8867% <ø> (-4.2313%) ⬇️

@SeaRise
Copy link
Contributor Author

SeaRise commented Oct 8, 2023

/test check-dev

@tiprow
Copy link

tiprow bot commented Oct 8, 2023

@SeaRise: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Oct 8, 2023

/cc @Defined2014 @hawkingrei @YangKeao @windtalker @tiancaiamao

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2023
windtalker
windtalker approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-08 02:25:17.765467957 +0000 UTC m=+932715.352578087: ☑️ agreed by Defined2014.
  • 2023-10-08 03:06:52.639495389 +0000 UTC m=+935210.226605535: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit b431900 into pingcap:master Oct 8, 2023
14 of 16 checks passed
@Defined2014 Defined2014 mentioned this pull request Oct 8, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@YangKeao YangKeao Awaiting requested review from YangKeao

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeaRise @windtalker @Defined2014